DOI-USGS / lake-temperature-model-prep

Pipeline #1
Other
6 stars 13 forks source link

Check nhdhr manual tags #314

Closed padilla410 closed 2 years ago

padilla410 commented 2 years ago

This PR corrects a typo in the 4_params_munge portion of the pipeline

Verification of a successful rebuild of 4_params_munge/out/MO_manual_depths.rds.ind:

> readRDS(sc_retrieve('4_params_munge/out/MO_manual_depths.rds.ind'))
# A tibble: 8 x 2
  site_id         z_max
  <chr>           <dbl>
1 nhdhr_120032270  40  
2 nhdhr_120032533  64  # <-- NHDHR typo correction here
3 nhdhr_120032180  25.9
4 nhdhr_106716325  32.0
5 nhdhr_168123531  15.5
6 nhdhr_120032495  14.3
7 nhdhr_105341319  53.9
8 nhdhr_120032884  67.1

Verification of successful rebuild of 8_viz/inout/lakes_summary.feather.ind that includes a zmax for Bull Shoals:

> arrow::read_feather('8_viz/inout/lakes_summary.feather') %>% filter(site_id == 'nhdhr_120032533')
# A tibble: 1 x 15
  site_id         GNIS_Name        n_obs n_profiles longitude latitude zmax  hypsography hypsography_digitizing kw    kw_file meteo obs_category main_source Lake_Source
  <chr>           <chr>            <int>      <int>     <dbl>    <dbl> <lgl> <lgl>       <lgl>                  <lgl> <lgl>   <lgl> <chr>        <chr>       <chr>      
1 nhdhr_120032533 Bull Shoals Lake  2997        132     -92.8     36.5 TRUE  FALSE       FALSE                  TRUE  FALSE   TRUE  50+ profiles NA          ""  

Verification that all of the manual NHDHR IDs are correct:

> manual_nhdhr <- c('nhdhr_120032270', 'nhdhr_120032533', 'nhdhr_120032180',
+                   'nhdhr_106716325', 'nhdhr_168123531', 'nhdhr_120032495', 
+                   'nhdhr_105341319', 'nhdhr_120032884')
> 
> row_count <- arrow::read_feather('8_viz/inout/lakes_summary.feather') %>% 
+   filter(site_id %in% manual_nhdhr) %>% 
+   nrow()
> 
> all.equal(length(manual_nhdhr), row_count)
[1] TRUE