DOI-USGS / lake-temperature-model-prep

Pipeline #1
Other
6 stars 13 forks source link

Update time #336

Closed jordansread closed 2 years ago

jordansread commented 2 years ago
image

^ big changes after updating NLDAS to the whole CONUS.

Getting this in now because it has build/ind updates and will provide more context and explanation tomorrow.

Fixes #328 but this included some clean-up in how we were dealing with NLDAS data as specified originally in #1

jordansread commented 2 years ago

This PR moves away from the rectangle-based NLDAS driver file builds originally created in #1. What the prior solution was doing was setting a rectangle to pull NLDAS NetCDF files for all time (but chunked into files of 25k steps each), writing all of the time values to single feather files for each variable and cell (still at native hourly NLDAS resolution) and then combining the variables into a single daily .csv for each cell. This process worked fine but each time we wanted to update time or space we had to set the appropriate rectangle and build the files.

The new method I've coded works mostly the same but instead of using multiple rectangles in a mosaic covering our study area, it uses the single CONUS footprint here. The indicator file from that build now lands in our in here and the other things work mostly the same.

But, since we're no longer moving along these rectangles, which were manageable to build the files, I'm now grouping cells spatially in task plans so that chunks of cells and chunks of driver files are written per task, as opposed to a GLM .csv per task which was the old workflow and not scalable. So that's what the other main changes are. Then some clean-up I took care of when I was in there.

jordansread commented 2 years ago

I'm not sure this makes sense for a normal PR review, but I'd be happy to do a "explain it while we walk through it" type review if that would work better. @lindsayplatt I will defer to you as to how you'd prefer review works on this one.

lindsayplatt commented 2 years ago

@jread-usgs an explain it while we walk through it (maybe 15-20 min max?) would be good. I'd also like to know if the changes her impact how we use the NLDAS drivers in downstream model runs- would we need to change anything there?

lindsayplatt commented 2 years ago

Love seeing n=0 next to "GLM, but no meteo"!! 🚀