search

DOI-USGS / lake-temperature-process-models

Creative Commons Zero v1.0 Universal
1 stars 4 forks source link

change order of gcm name and site id in outfile file name template #27

Closed hcorson-dosch-usgs closed 2 years ago

hcorson-dosch-usgs commented 2 years ago

Tiny edit to switch the GLM output naming convention from 'GLM_{site_id}_{GCM name}.feather' to 'GLM_{GCM name}_{site id}.feather' to aid with regex work in lake-temperature-out

_Note: to be consistent, we could also change the naming conventions for the temporary feather files generated for each lake-gcm-time-period combo during model execution here, but I'm not making that change now as it would trigger a full rebuild of the models, as opposed to just regenerating the output feathers for each lake-gcm combo by rebuilding p3_glm_uncalibrated_output_feathers_

hcorson-dosch-usgs commented 2 years ago

Note: we will want to merge this in before the next full model run

lindsayplatt commented 2 years ago

I'm not as convinced about this reorder now. It's a bit of a coding work-around to handle it in lake-temperature-out but I am OK with that bc it feels like the appropriate grouping is actually how it currently is named. The downstream use-cases are for GCMs to be compared across each site rather than the sites compared across each GCM. Sorry for reverting this idea!