search

DOI-USGS / mda.streams

backend tools for powstreams
Creative Commons Zero v1.0 Universal
3 stars 8 forks source link

code for using rds #222

Closed jordansread closed 8 years ago

jordansread commented 8 years ago

Note that tsv is still the default for all of these functions, and I think it should stay that way until we are ready to make the switch over.

I have tested a number of cases here, including mixed versions on one ts (e.g., tsv and rds), using replace, merge, stop and skip on combinations.

tidyr has been added to support the goofy thing we ran into with NWISweb services, where we can't assume a single column for data. This uses gather and figures out which data column actually has more data for that site, and uses it. Kind of goofy code in there, so if anyone has a better way of doing it...

This ended up touching a lot of code, so it will need a review. @aappling-usgs can you review?

jordansread commented 8 years ago

working on fixing test that broke

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 18.32% when pulling f71ee9e9d24cf7ad091b04674642244966459e0c on jread-usgs:develop into 9f9d86d05c4cb4706ace7c7403d7b55f0e0c4105 on USGS-R:develop.

jordansread commented 8 years ago

OK @aappling-usgs I think I feel good about this, but let me know if you have other suggestions.

aappling-usgs commented 8 years ago

looks good to me!