DOI-USGS / mda.streams

backend tools for powstreams
Creative Commons Zero v1.0 Universal
3 stars 8 forks source link

fix #291, start #284 #293

Closed aappling-usgs closed 7 years ago

aappling-usgs commented 7 years ago

updating deps to their https-compatible versions working on adding a curve that integrates modeled (smooth) and observed (data) time series of light. (the actual logic is in streamMetabolizer)

aappling-usgs commented 7 years ago

error #3 is new, i think, but maybe still related to the ongoing data pull?

testthat results ================================================================
  OK: 89 SKIPPED: 0 FAILED: 3
  1. Error: combine_ts works (@test-combine_ts.R#4) 
  2. Error: get_ts works (@test-get_ts.R#6) 
  3. Error: internal function get_sites works for multisites (@test-list_and_get_info.R#4)
aappling-usgs commented 7 years ago

error 3 only occurs on appveyor, not travis

aappling-usgs commented 7 years ago

appveyor fails on this example, which works locally:

get_site_coords(c("nwis_01467200","styx_001001","nwis_351111089512501","nwis_07239450")) 
Error: GET failed to https://www.sciencebase.gov/catalog/items/. check authorization and/or content

oh, but that's because styx sites are hidden now. my bad

aappling-usgs commented 7 years ago

appveyor note:

calc_ts_par_calcLatSw: no visible global function definition for
  'calc_light_merged'
Undefined global functions or variables:
  calc_light_merged

that should be resolved when the streamMetabolizer PR gets merged.

these errors are mostly/all because data are being re-pulled right now, i hope:

  testthat results ================================================================
  OK: 59 SKIPPED: 0 FAILED: 7
  1. Error: combine_ts works (@test-combine_ts.R#4) 
  2. Error: config files can be staged (@test-config.R#5) 
  3. Error: config files can be verified (@test-config.R#19) 
  4. Error: get_ts works (@test-get_ts.R#6) 
  5. Error: internal function get_sites works for multisites (@test-list_and_get_info.R#4) 
  6. Error: list_datasets  (@test-list_and_get_info.R#15) 
  7. Error: get_site_coords works (@test-list_and_get_info.R#28)
aappling-usgs commented 7 years ago

travis stalled. going ahead.