search

DOI-USGS / meddle

Tools for metadata creation and data releases
Other
0 stars 10 forks source link

FGDC standards update + yaml package change default behavior #78

Closed limnoliver closed 2 years ago

limnoliver commented 2 years ago

With the field descgeog populated, we get an informative error and warning from the FGDC metadata check. image

The error is saying it no longer expects the description in the spatial domain section, and I can't find anywhere else it is supposed to be. The warning is saying the bounding box is out of order -- it is expecting the bounding box field to be first in the spatial domain section. Manually removing descgeog field from the same xml removes the informative error and warning.

Additionally, yaml::yaml.load changed default behavior to not automatically convert expressions. See this change: https://github.com/vubiostat/r-yaml/commit/d236f9a0ab821f88e2ca855fb48ae4ccc8e16923

jordansread commented 2 years ago

The yaml:: update is a no-brainer.

But I want to dig a little deeper on descgeog as we added that section 3 years ago (unfortunately, with a not very useful commit message) and I think it was because we were getting errors from the SB team's metadata wizards validation check, which actually doesn't always agree with the upload service that you've used here (and I've used in the past).

Sciencebase renders this field as this ("Description of Geographic Extent"):

image

And I think we get dinged if we don't have it when they use their automated review before the data release goes public.

limnoliver commented 2 years ago

Ahh okay, thanks Jordan. I'll revert this edit and live with the informative warnings/errors.

limnoliver commented 2 years ago

@jread-usgs - can you merge? I don't have the power.