In a surprising turn of events, it turns out that American Samoa, Guam, and the Northern Marianas do have a HUC code - it's "22". Our own documentation on this surprise is not consistent:
There are two sites that are missed when we query by HUC rather than stateCd, they have the following characteristics:
located in the Northern Marianas
Site Type == spring
Data is >= 20 years old
I would assume that we would probably miss some NWIS sites the CONUS + AK + HI + Caribbean regions if we did the same HUC vs stateCd comparison. I did not test this theory because creating the inventory for CONUS + AK + HI + Caribbean was running slowly for me (> 30 min). Because of this assumption, I have decided to keep the query method consistent for all regions.
I am tagging @limnoliver for this review because this is more of a overall "methods" PR rather than an in depth pipeline review.
In a surprising turn of events, it turns out that American Samoa, Guam, and the Northern Marianas do have a HUC code - it's "22". Our own documentation on this surprise is not consistent:
To dig into these inconsistencies a bit I have a snippet of code:
There are two sites that are missed when we query by
HUC
rather thanstateCd
, they have the following characteristics:I would assume that we would probably miss some NWIS sites the CONUS + AK + HI + Caribbean regions if we did the same
HUC
vsstateCd
comparison. I did not test this theory because creating the inventory for CONUS + AK + HI + Caribbean was running slowly for me (> 30 min). Because of this assumption, I have decided to keep the query method consistent for all regions.I am tagging @limnoliver for this review because this is more of a overall "methods" PR rather than an in depth pipeline review.
Closes #19