search

DOI-USGS / ncdfgeom

NetCDF-CF Geometry and Timeseries Tools for R: https://code.usgs.gov/water/ncdfgeom
https://doi-usgs.github.io/ncdfgeom/
15 stars 7 forks source link

more flexibility in write_dsg #81

Closed jordansread closed 2 years ago

jordansread commented 2 years ago

Wondering if you'd entertain this added flexibility in write_dsg()

This let's the user define instance_dim_name and dsg_timeseries_id, and if they are missing, it uses the prior behavior.

codecov-commenter commented 2 years ago

Codecov Report

Merging #81 (063c0fd) into master (9a1c8ee) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head 063c0fd differs from pull request most recent head 5a38f53. Consider uploading reports for the commit 5a38f53 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   96.71%   96.73%   +0.01%     
==========================================
  Files           9        9              
  Lines         730      734       +4     
==========================================
+ Hits          706      710       +4     
  Misses         24       24
Impacted Files Coverage Δ
R/write_timeseries_dsg.R 99.04% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a1c8ee...5a38f53. Read the comment docs.

jordansread commented 2 years ago

These spaces/tabs/newlines are driving me nuts and I'm booked solid with meetings, so going to need to let this hang here.

dblodgett-usgs commented 2 years ago

Don't worry about it. I was just pointing it out for awareness.