search

DOI-USGS / ncdfgeom

NetCDF-CF Geometry and Timeseries Tools for R: https://code.usgs.gov/water/ncdfgeom
https://doi-usgs.github.io/ncdfgeom/
18 stars 8 forks source link

for #94 -- normalized weights #96

Closed dblodgett-usgs closed 9 months ago

dblodgett-usgs commented 9 months ago

Added the reprex shown in #94 to tests -- should be solid.

dblodgett-usgs commented 9 months ago

@elliewhite-usgs -- Can you try out the normalized weights in a workflow and see if this seems correct?

codecov-commenter commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f0808d3) 91.85% compared to head (88a1d13) 91.74%. Report is 10 commits behind head on main.

:exclamation: Current head 88a1d13 differs from pull request most recent head bf3da0a. Consider uploading reports for the commit bf3da0a to get more accurate results

Files Patch % Lines
R/calculate_area_intersection_weights.R 90.90% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #96 +/- ## ========================================== - Coverage 91.85% 91.74% -0.11% ========================================== Files 11 11 Lines 896 909 +13 ========================================== + Hits 823 834 +11 - Misses 73 75 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.