Gripe more then issue: Topology specification

DOI-USGS / nhdplusTools

See official repository at: https://code.usgs.gov/water/nhdplusTools

https://doi-usgs.github.io/nhdplusTools/

Creative Commons Zero v1.0 Universal

85 stars 32 forks source link

Gripe more then issue: Topology specification #350

Open mikejohnson51 opened 1 year ago

mikejohnson51 commented 1 year ago

It is difficult to build a smooth workflow when both calculate_arbolate_sum and add_plus_network_attributes are needed because the former requires a ID/toID topology and the latter a comid/tocomid topology.

Would you be interested in changing add_plus_network_attributes to need the more general ID/toID set?

dblodgett-usgs commented 1 year ago

Yeah... there's still some messiness to all the attribute handling. That would be possible in hydroloom -- but I haven't packaged it up that way.

Once the hydroloom branch is out, a lot more will be possible.

dblodgett-usgs commented 1 month ago

@mikejohnson51 -- are you still using the functions from nhdplusTools for these? Think it's worth the time to clean up here or should we maybe just deprecate the functions in nhdplusTools?