search

DOI-USGS / nhdplusTools

See official repository at: https://code.usgs.gov/water/nhdplusTools
https://doi-usgs.github.io/nhdplusTools/
Creative Commons Zero v1.0 Universal
85 stars 32 forks source link

geoconnex reference features client #386

Closed dblodgett-usgs closed 2 months ago

dblodgett-usgs commented 4 months ago

Need a basic client for geoconnex reference features.

Something like:

#' discover geoconnex reference feature layers
#' @return data.frame containing layers available and fields that are available to query.
discover_geoconnex_reference <- function() {}
#' get geoconnex reference feature layers
#' @return sf data.frame contianing requested reference features
get_geoconnex_reference <- function(AOI = NULL, ids = NULL, type = NULL, t_srs = NULL, buffer = 0.5) {
}
ksonda commented 4 months ago

backlog:

maybe allow fuzzy matching based on name, where name is whatever the json-ld context has mapped to schema:name.

dblodgett-usgs commented 4 months ago

Something I came across... it seems that the bbox filter is comparing feature bboxes rather than actual feature intersection?

When I request mainstems in a bbox for the area in the upper right here, I get way more rivers than I would expect.

image

ksonda commented 4 months ago

This would appear to be a pygeoapi issue, possibly at the top level of bbox, possibly with just the postgis provider, depending on what FGDC is backing its collections with.

https://geoapi.geoplatform.gov/collections/62e48e3e_c8e9_4d48_990b_44dbb8265dd0/items?bbox=-111.020099,44.956318,-110.953495,44.971865

from this bbox

image