search

DOI-USGS / scipiper

https://usgs-r.github.io/scipiper/index.html
Creative Commons Zero v1.0 Universal
9 stars 12 forks source link

target types vignette #110

Closed wdwatkins closed 5 years ago

aappling-usgs commented 5 years ago

I'm not sure what's happening with the build, given that the master branch is building without error and all you've done is added a vignette .Rmd file. Maybe the issue is occurring (proximately, anyway) because this vignette doesn't currently have a built version in the repo. You could try calling devtools::build_vignettes() locally, then manually moving the doc folder into inst (to make inst/doc/.*), then committing the new built-vignette files (.Rmd, .html, .R) for this vignette.

And when you have a final version of the vignette ready to go, please also copy the .html file into the docs folder for easy viewing on github.io.

wdwatkins commented 5 years ago

I got this error locally as well, actually: 

Warning in file(con, "r") :
  cannot open file 'script.R': No such file or directory
Quitting from lines 46-68 (task_plans.Rmd) 
Error in file(con, "r") : cannot open the connection
ERROR: installing vignettes failed

It went away after rebuilding and running tests again 🤔

aappling-usgs commented 5 years ago

Strange. Did you try the devtools::build_vignettes solution I suggested above?

wdwatkins commented 5 years ago

Yes, just pushed those updates up.

aappling-usgs commented 5 years ago

Hmm. I'm only seeing 3 total files pushed, was expecting 6:

wdwatkins commented 5 years ago

Looks like git was ignoring them since doc is ignored, and that must have made them still ignored in inst/doc

aappling-usgs commented 5 years ago

Hey, it worked! Annoying, but Laura and I spend at least a day trying to work around it and had to give up, so I think this is the best bet for this and future vignettes for a while.

I wonder if our .gitignore is set up improperly. We do have !inst/doc, so I'd think things wouldn't be ignored in that folder, but maybe the doc line needs start/end line characters included, or maybe the order of !inst/doc and doc matters...something to look into someday.

aappling-usgs commented 5 years ago

Have you made all the vignette changes you plan to make, @wdwatkins ?

wdwatkins commented 5 years ago

Yes, ready for you to review again.

I would guess the order of the two ignore lines matters.

wdwatkins commented 5 years ago

I also wonder if there is some funniness going on in the task plans vignette that makes it not build the first time it runs, but then it uses existing temp files or something the second try, and it works. There's no reason I can see for this PR to effect another vignette building or not. I took a quick look and didn't see anything obvious though. 🤷‍♂