Closed hcorson-dosch-usgs closed 3 years ago
One more commit coming shortly
The first two maps on the monitoring page are too tall to fit on my laptop screen:
Note removed single faulty obs for segment 1764 in 8/2019 - Sam reviewed the data and decided that the obs for 8/21 was faulty. Both of those days were > 90 degrees, with no rain in between:
The obs were from two different sites, that are near to one another:
I truly love the temperature variability part!
When I hover on a reach with only a few observations and they are points rather than line segments, it's hard to make out the observations. The mouseover pop up saying 0 or 6 obs etc helps with that. Are these usually single observations separated by a lot of NA's? I want to suggest boosting the stroke width a little bit more for just those points, but I'm not sure how straightforward that would be to do if everything coded is a path. If that's the case then don't worry about it.
I'd also consider boosting the size of the temperature variability map to be the same height as the y on the line chart.
Mobile sizing of bar chart a little funny:
Text wrapping is funny on mobile here, and caption text is super small:
re: mobile view -- I haven't yet edited mobile at all. The mobile version will have totally different svgs
Is this text current to the new data added? "The 5 most frequently monitored river reaches – only 1% of all monitored river reaches – account for nearly 20% of all stream temperature data."
Is this text current to the new data added? "The 5 most frequently monitored river reaches – only 1% of all monitored river reaches – account for nearly 20% of all stream temperature data."
Not sure - @limnoliver do you know if this statement still holds?
When I hover on a reach with only a few observations and they are points rather than line segments, it's hard to make out the observations. The mouseover pop up saying 0 or 6 obs etc helps with that. Are these usually single observations separated by a lot of NA's? I want to suggest boosting the stroke width a little bit more for just those points, but I'm not sure how straightforward that would be to do if everything coded is a path. If that's the case then don't worry about it.
Not a big deal to do, but looks odd, probably b/c of how the paths are coded. They are single obs separated by NAs (this is stroke width of 15):
LOL yeah, I think non-connected observations would have to be coded as circles to make that idea work. Let's just leave it how you had it
Another thought is that the section before "availability" is a little repetitive:
The two text paragraphs leading into the chart are essentially the same as the caption. IMO, the last two paragraphs before the chart could be folded into the caption. I really like the "in the dark" part and emphasizing space and time and that could go well in the first caption sentence. The second caption sentence could be meshed with the paragraph right before it.
Anyways, this is unsolicited text feedback so feel free to ignore me
"The 5 most frequently monitored river reaches – only 1% of all monitored river reaches – account for nearly 20% of all stream temperature data."
The numbers have shifted a bit. 4 sites is now 1% of reaches and makes up 16% of data. 5 sites is 1.5% of reaches and makes up 19% of data. Maybe go for 7 sites/2% of sites/25% of data.
Maybe reduce (and with changes suggested in my last comment) the availability text to:
But don't let the sheer amount of data fool you. Most records of stream tempearture are concentrated at just a few sites across the basin.
The 7 most frequently monitored river reaches – only 2% of all monitored river reaches – account for 25% of all stream temperature data. There are whole chunks of space and time where we don't know anything about the river, where we are "in the dark."
To show how gaps in temperature observations in space and time might impact our understanding of stream temperature dynamics, we can represent the availability of data as a matrix with two axes: space and time. Some streams are monitored daily, others at regular intervals, and some sporadically or not at all. It is more difficult to predict how temperature in a stream will fluctuate when we don't have much data to go on.
Explore the availability of temperature observations across the DRB by selecting a river reach (on the left) or a year (on the right) to explore where and when we have the most information.
The caption + dropdown explainer says the rest? Or do we need to add something to the caption in case they don't hit the explainer?
^^ that looks great to me, we could add phrasing to the caption to include "observations in space and time"
Thanks @limnoliver and @collnell -- I'll add these changes in a new commit
Before making a pull request
First . . .
Then check for accessibly compliance
Then run Browserstack; check that application works on . . .
Finally . . .
Title
Brief description of changes. Reference the JIRA ticket if appropriate
Description
If no ticket is referenced, describe the changes made. Note anything that you want the reviewers to know while reviewing your pull request
After making a pull request