search

DOI-USGS / temperature-prediction

Other
7 stars 10 forks source link

for non-NA islands where there is only one coordinate, make sure it s… #239

Closed lindsayplatt closed 3 years ago

lindsayplatt commented 3 years ago

@hcorson-dosch was noticing that some paths in the timeseries SVG weren't drawn. Turns out after our NA fix, we had some "paths" that were only made up of one point and so the point was "moved to" with M but nothing ever drawn. This adds a second point just slightly further away to draw a tiny dash/point so that we can see those lonely non-NA values in the chart :) Notice the dashes below

image

Wondering if I should shrink the size so they are more like dots instead of dashes ... easy to change to make. Here's a second option (not what is in this PR, but could be changed):

image

hcorson-dosch-usgs commented 3 years ago

@lindsayplatt -Nice fix!! If it's a quick change, let's go ahead and shrink these a bit so that they look more like dots. Then I'll merge it in and check the interaction.

lindsayplatt commented 3 years ago

@hcorson-dosch shrunk!