search

DOI-USGS / usgscsm

This repository stores USGS Community Sensor Model (CSM) camera models
Other
26 stars 33 forks source link

Remove computeAllSensorPartials from Frame and Ls sensor model or modify to call parent after logging #305

Closed kberryUSGS closed 4 years ago

kberryUSGS commented 4 years ago

It's not needed, as this is implemented in RasterGM. The Ls sensor model's function does add logging, but if we want to keep the logging, we can leave this method in the Ls sensor model, and have its entire contents be (1) logging (2) call the parent's (RasterGM's) version of this function.

jlaura commented 4 years ago

Is this closable? Looks like the auto close in #311 just might not have worked?

kberryUSGS commented 4 years ago

Yes, thanks! Closed by #311