This PR contains the result of running just clang-format style=Google on the usgscsm code. This standardizes spacing, bracket-placement, header-ordering, max line length, etc, but doesn't contain changes resulting from static analysis and cpplint does still find some additional changes that need to be made by hand. (I'm not sure if these additional changes should be in this PR or a subsequent one. I was leaning toward a subsequent one just so the automated changes and hand-changes could be in separate PRs. The changes left to be made are a much smaller list than the changes in this PR.)
I tested a few formats, and picked Google style because I somewhat arbitrarily liked the way the results looked the best. I have results locally for the following formats if anyone would like to see some alternatives: LLVM, GNU, Mozilla, Chromium, WebKit. I picked these to test because clang-format could automatically fix code to follow these standards. I'm also open to other "auto-fix formatting" tools if anyone has any other suggestions!
kberryUSGS
commented
4 years ago
This PR contains the result of running just
clang-format style=Googleon the usgscsm code. This standardizes spacing, bracket-placement, header-ordering, max line length, etc, but doesn't contain changes resulting from static analysis andcpplintdoes still find some additional changes that need to be made by hand. (I'm not sure if these additional changes should be in this PR or a subsequent one. I was leaning toward a subsequent one just so the automated changes and hand-changes could be in separate PRs. The changes left to be made are a much smaller list than the changes in this PR.)I tested a few formats, and picked Google style because I somewhat arbitrarily liked the way the results looked the best. I have results locally for the following formats if anyone would like to see some alternatives: LLVM, GNU, Mozilla, Chromium, WebKit. I picked these to test because
clang-formatcould automatically fix code to follow these standards. I'm also open to other "auto-fix formatting" tools if anyone has any other suggestions!