search

DOI-USGS / usgscsm

This repository stores USGS Community Sensor Model (CSM) camera models
Other
26 stars 33 forks source link

Expansion of the usgscsm_cam_test tool and documentation #377

Closed oleg-alexandrov closed 2 years ago

oleg-alexandrov commented 2 years ago

I addressed all issues above. In particular there's a new test to load back the model state saved by the previous test.

As to adding units tests for individual functions, that may be a little too fine-grained and I don't see the point much. They are very small utilities and get tested by the two tests already in.

jessemapel commented 2 years ago

I'm okay with merging this if the windows json stuff continue to be a problem

oleg-alexandrov commented 2 years ago

Thanks. I think you can pull it in. The windows error is because of getopt.h is missing. That's what I use now to parse command line options. I will think of what to do about that. Maybe using boost, but that is not in libusgscsm's dependencies, and I would not want to add it. I'll try to implement a simple command line parser or something.

jessemapel commented 2 years ago

We may be able to use something like this depending on licensing https://github.com/Chunde/getopt-for-windows