search

DOI-USGS / usgscsm

This repository stores USGS Community Sensor Model (CSM) camera models
Other
26 stars 33 forks source link

GXP supfile integration and tests #409

Closed AustinSanders closed 2 years ago

AustinSanders commented 2 years ago

Closes #400

jessemapel commented 2 years ago

Also, how big is the .sup file? GitHub won't render it so I'm curious what the size of the file is.

thareUSGS commented 2 years ago

The current .sups are likely fairly large since they are HiRISE. So perhaps for the tests simply using a framer or maybe CTX. CTX sups/states should only be ~40KB.

jessemapel commented 2 years ago

@thareUSGS @amystamile-usgs @AustinSanders what's the status on this?

thareUSGS commented 2 years ago

@jessemapel ooh I thought this was pulled in already. I would be happy to see this capability merged. I don't think it has been extensively tested, but I have tested the ASP updated "sup" file in GXP successfully (which is to test an updated camera state from ASP into GXP). The opposite direction was tested by Oleg in ASP (I think). Taking camera state directly from a GXP "sup" file into ASP. If not tested in ASP, I know it was tested in the usgscsm utility app.

jessemapel commented 2 years ago

The problem with this PR is that it has no automated testing on it. It cannot be merged until there is automated testing added, so there's more work that needs to be done. Is there a plan to do that?

thareUSGS commented 2 years ago

@jessemapel I'm not sure what is needed for testing but there were updates to: https://github.com/USGS-Astrogeology/usgscsm/pull/409/files#diff-525f51116b059e04f880e591aee61e45ed292c61e40b92e6d44a22f1103087ef and Not sure what the "hello" test is doing. Looks to be a stub for a test? https://github.com/USGS-Astrogeology/usgscsm/pull/409/files#diff-8dd74769e65dadd96bbddce40388b7164ee3b2a40b9220b188b621bb3c1b0b9a

I can simply vouch that it would be great to have this completed (with tests) and merged. If it requires more work, then I am happy to try to get that supported somehow. Otherwise, I guess I can try to support the needed tests.

AustinSanders commented 2 years ago

@jessemapel I've been planning on taking care of this with continuous support, but I let it slip through the cracks so far. I can spend a few hours this week writing tests.

jessemapel commented 2 years ago

There's not rush on getting this done. I was just peeling a release, so I wanted to check and see if there was a plan or if I should delay this. This can go into the end of the fiscal year clean-up work.