DOI-USGS / usgscsm

This repository stores USGS Community Sensor Model (CSM) camera models
Other
26 stars 33 forks source link

FrameSensor: Make many members public so they can be changed #455

Closed oleg-alexandrov closed 1 year ago

oleg-alexandrov commented 1 year ago

The FrameSensor class has its members private, but has no set or get functions so those cannot be accessed. This is a proposal to make them public, as done already for the Linescan class. (A few members will still be kept private, which are internal states, such as the logger and the _state variable).

I care primarily for the intrinsics (distortion, focal length), camera position, and camera orientation, as those are needed in bundle adjustment. But I don't think there's harm in having other class parameters be public, such as semi-major axis, semi-minor axis, etc.

Thoughts?

Kelvinrr commented 1 year ago

I personally have no objection to making what would essentially be ISD components public. Makes sense to be able to modify those as needed directly without having to add setters and getters or similar.

oleg-alexandrov commented 1 year ago

Any further thoughts on this?

Kelvinrr commented 1 year ago

Nah I think this is fine if no one else has objections

oleg-alexandrov commented 1 year ago

Can this be merged in?