DOI-USGS / vizlab-home

Landing page for the USGS Vizlab
Other
5 stars 6 forks source link

Add chart challenge 2023 to vizlab homepage #36

Closed hcorson-dosch-usgs closed 1 year ago

hcorson-dosch-usgs commented 1 year ago

Changes made:

Add new section to the 'Visualizations' portion of the site that includes a carousel of the 2023 chart challenge charts. EDIT: ~For now (for visual consistency) the carousel is placed inside an accordion. As we move away from the accordions we can change that (or we could drop now, would just need to style the 'Chart Challenge 2023 header' differently to match the accordion header settings (minus the triangle))~ It was bothering me to have such a short section in an accordion, so I took it out.

image

Fullscreen: image

Changes:

Note:

Other small edits

Testing:

Before making this pull request, I:

I can confirm this has been checked on:

hcorson-dosch-usgs commented 1 year ago

It took a long time for one of the images to load when I clicked on it. Looking at the pipeline, it seems like we're serving up the full size images as thumbnails, is that right? Do all of the images load once any single image is clicked on?

Agreed that something is up w/ how the images are loaded. I think the full-size images are being loaded as the thumbnails instead of the webp versions. I've created a new issue #37 to look into that in another PR

Carousel navigation: I think some sort of side navigation is needed to show that there are more images in the carousel. You can see that by clicking the dots below, but it is pretty subtle. Something pointing to the right would help guide the user.

Oh good thought. I added the navigation controls: image

Placement: I think it's fine to put this at the top above the interactives, but it feels very separate from the chart gallery and as a user, I might not understand the distinction. What do you think about making this carousel a part of the chart gallery - like the chart challenge is a subset of the chart gallery?

I've moved it into the chart gallery, as a subsection:

image

Contents: To simplify the chart gallery and fit better together - what about including any of the past chart challenge charts here as well?

We could do this - I think we'd want to modify the captions to something like '2023 contribution for ....'. Only thing is, I'm pretty sure there are no charts in the chart gallery from 2022, so right now it would just be adding these 5: image

cnell-usgs commented 1 year ago

This looks good to merge.

We should add the 2022 charts into the chart gallery also, but that can happen later. I think it would also be great to adapt use the carousel in some other places - like for river conditions and flow tiles and snow tiles.

hcorson-dosch-usgs commented 1 year ago

We should add the 2022 charts into the chart gallery also, but that can happen later. I think it would also be great to adapt use the carousel in some other places - like for river conditions and flow tiles and snow tiles.

Agreed! I'll add some issues now