DOI-USGS / vizlab-home

Landing page for the USGS Vizlab
Other
5 stars 6 forks source link

Make horizonal card groups filtered by "group" tag #4

Closed ellenbechtel closed 2 years ago

ellenbechtel commented 2 years ago

Changes made:

Plugged in a card component into an accordion component and use props to dynamically populate based on filtered lists

Testing:

Before making this pull request, I:

I can confirm this has been checked on:

cnell-usgs commented 2 years ago

I think this is fine to merge, but I want to reconsider the use of the accordion or add some function to limit the number of cards shown in each section.

The first group of cards needs to be more general. This should include all of our biggest effort pieces that we want to direct people too, like the temperature prediction pages and past vizzies like the water use one, the drought ones, fish, etc. I think we should make the basin one "All" minus hurricanes, river conditions, and potentially smaller one offs shared on twitter as another section. That, in addition to my comments about the river conditions and hurricanes, will contribute to some navigation and organizational challenges. If every card is showing that page will be really long. I'm not sure the best solution but a carousel might be useful to contain river conditions and hurricanes, since older versions are not going to be that popular.

Another thing I want to simplify is the number of headers and titles when you first land on the page. It's hard to know where to look and it seems like there's more structure than needed.

Screen Shot 2021-09-03 at 1 06 20 PM