DOI-USGS / water-use

Visualization using USGS water use data.
https://owi.usgs.gov/vizlab/water-use/
Creative Commons Zero v1.0 Universal
15 stars 16 forks source link

Response to reviewers #154

Closed ldecicco-USGS closed 7 years ago

ldecicco-USGS commented 7 years ago

Reviewer 1 comments (MN):

Reviewer 2 comments (NB):

jordansread commented 7 years ago

For the USGS symbol comment - I think the symbol is supposed to be a watermark for the map, so it shouldn't stand out, it should instead make sure that the attribution follows re-use of the figure. I don't want to emphasize that on the map because any point of emphasis we put in there takes away from emphasizing the data. However, we could make the watermark the same color as the state backgrounds (right now it looks slightly lighter).

dblodgett-usgs commented 7 years ago

If #155 is merged, the checks I added are legit.

dblodgett-usgs commented 7 years ago

I'd say the 'Other' category is a won't fix. That would both be a ton of work and could be misleading because of how things have changed over time.

eread-usgs commented 7 years ago

@ldecicco-USGS thanks for putting this into an issue.

eread-usgs commented 7 years ago

I updated the top comment with Nancy's comments. I think the remaining fixes should be pretty trivial, but text added to the no data state/time combos, and to the overall Instructions/Explanations comment from Martha may need some discussion and thought @jread-usgs looking at you for these ones.

eread-usgs commented 7 years ago

@jread-usgs and I are going to take these remaining issues on Friday evening.

jordansread commented 7 years ago

Should we just go ahead and change the marker back to a square?

eread-usgs commented 7 years ago

sure