search

DOI-USGS / water-use

Visualization using USGS water use data.
https://owi.usgs.gov/vizlab/water-use/
Creative Commons Zero v1.0 Universal
15 stars 16 forks source link

analytics #156

Closed wdwatkins closed 7 years ago

wdwatkins commented 7 years ago

Currently recording category changes, year changes with each category, and state hovers > 2 sec

wdwatkins commented 7 years ago

123

jordansread commented 7 years ago

@wdwatkins where do these functions get associated with the svg elements? Must have missed that

wdwatkins commented 7 years ago

Uhh I'm guessing something in the svg calls these JS functions? @jiwalker-usgs ?

jordansread commented 7 years ago

What do you need "fix for edge states"? Are those edge cases or actual states on the edges of the map?

wdwatkins commented 7 years ago

Actual states on the edge of the map, the delay count for the ga call doesn't get cut off when the mouse leaves the map. So the last state you touch always hits ga regardless of time you hovered on it. As @jiwalker-usgs mentioned in his review

wdwatkins commented 7 years ago

@jiwalker-usgs @jread-usgs How much of a priority is a fix for ☝️ ? Seems like it requires some modifications beyond just where we put the ga() call.

jiwalker-usgs commented 7 years ago

The main thing I'm concerned with is flooding google with too many events, I think biasing towards coastal states with our analytics will just be something we have to deal with.

eread-usgs commented 7 years ago

@jread-usgs can you comment on @wdwatkins question and @jiwalker-usgs 's response? Want to get this wrapped up...

jordansread commented 7 years ago

I don't think we should collect data on it if we can't remove the coastal bias. It would be really hard to use the data.

I would vote we either solve the issue, or not track that event.

wdwatkins commented 7 years ago

It seems like solving it would require creating some kind of polygon for the area outside of the map. Then the counter would be reset when the mouse moves off the map, and we could do a check to not send analytics for that shape. But if that isn't worth doing, I'd say scrap it.

wdwatkins commented 7 years ago

Or if there is a way the hover can simply know that the mouse is over no shape.

jordansread commented 7 years ago

@wdwatkins there is a background rectangle for the whole thing, so if you are on top of that, you are on nothing else (because it is behind everything else). That may be a solution if you put mouseover event on that to end the count.

wdwatkins commented 7 years ago

issue with edge states should be fixed, now with thumbnail also for #103

jordansread commented 7 years ago

@jiwalker-usgs all good to merge?

jiwalker-usgs commented 7 years ago

I would say :shipit: