DOI-USGS / water-use

Visualization using USGS water use data.
https://owi.usgs.gov/vizlab/water-use/
Creative Commons Zero v1.0 Universal
15 stars 16 forks source link

IE doesn't support scale transitions #159

Closed jordansread closed 7 years ago

jordansread commented 7 years ago

is it the use of scale3d() or does it also not support scale?

jordansread commented 7 years ago

The issue here is that the states don't scale. The colors change but the sizes do not.

jordansread commented 7 years ago

If IE can't do scale() or scale3d() with css, we will probably just need to set the transform="scale(scale)" directly on the svg element. I don't think we should worry about animating this, just have it abruptly flip.

jordansread commented 7 years ago

https://connect.microsoft.com/IE/feedback/details/811744/ie11-bug-with-implementation-of-css-transforms-in-svg

IE11 supports SVG transforms through the 'transform' attribute but NOT through the near-identical CSS transform property - unlike all other browsers.

That is annoying, but tolerable.

Unfortunately, IE has convinced itself that it DOES support CSS transforms in SVG. This makes it very difficult to feature-detect. The transform property is present in the style object and both SVGElement.style.transform and SVGElement.style.msTransform return an empty string, implying that support is present.

However setting a CSS transform has no effect on SVG rendering. I am using IE11 on Windows 7 x64 pro.
jordansread commented 7 years ago

@mwernimont can you put a browser test for IE in this function and this function so we can slide some code in (like if (browser === IE){do things})?

mwernimont commented 7 years ago

@jiwalker-usgs is this a decent solution? http://stackoverflow.com/questions/19999388/check-if-user-is-using-ie-with-jquery

mwernimont commented 7 years ago

@jread-usgs #161 Has the global variables

ldecicco-USGS commented 7 years ago

OK, closing this issue because we're good enough. Note though, the lower bars were actually transitioning just fine. PR#167 made it so the states scale, but they don't have the smooth transition.