Bugfix some errors in scripts

DOMjudge / domjudge-packaging

DOMjudge packaging for (Linux) distributions and live image

31 stars 37 forks source link

Closed Dup4 closed 2 years ago

Dup4 commented 2 years ago

Obviously, the code in the loop has not taken offect.

${php_version} replacement was not successful.

Dup4 commented 2 years ago

BTW: I detected these errors by using shellcheck in vscode.

And shellcheck can also be run by GitHub Actions.
https://github.com/marketplace/actions/shellcheck
So do we consider adding the Actions in this repo, so that some errors can be detected in the PR phase, and it is convenient for the Reviewer to perform Code Review.
But I noticed that you mainly use gitlab CI, so I don't know what you think.
Or you can add related check in Gitlab CI.
After all, our goal is to eliminate errors, it has nothing to do with which platform is used, right?

nickygerritsen commented 2 years ago

Our main repo has some GitHub actions now. I leave it to @vmcj to think where to place shellcheck

vmcj commented 2 years ago

@Dup4 I've added shellcheck, so let's see what it can find besides your fixes.

Dup4 commented 2 years ago

good job. @vmcj

Looks like some issues have been detected

nickygerritsen commented 2 years ago

I think we can close this issue now by the way?

Dup4 commented 2 years ago

I think we can close this issue now by the way?

Yes.