DOMjudge / domjudge-packaging

DOMjudge packaging for (Linux) distributions and live image
32 stars 40 forks source link

Dir debian fixes #112

Closed vmcj closed 2 years ago

vmcj commented 2 years ago

Does not work, this is the result.

What is the intended benefit?

./configure \
  --enable-fhs \
  --prefix=/usr \
  --sysconfdir=/etc \
  --localstatedir=/var \
  \
  --with-domjudge_docdir=\"/share/doc/domjudge-doc \
  \
  --with-domserver_libdir=\"/share/domjudge \
  --with-domserver_libvendordir=\"/share/domjudge/lib/vendor \
  --with-domserver_webappdir=\"/share/domjudge/webapp \
  --with-domserver_logdir=/var/log/domjudge/domserver \
  \
  --with-judgehost_bindir=\"/sbin \
  --with-judgehost_libdir=\"/share/domjudge \
  --with-judgehost_libjudgedir=\"/lib/domjudge \
  --with-judgehost_chrootdir=/var/lib/domjudge/chroot \
  --with-judgehost_logdir=/var/log/domjudge/judgehost \
  \

I assumed so, the intended benefit was that:

but as the variable is filled by the one making the packages excluding the rule will make more sense.

eldering commented 2 years ago

Does not work, this is the result. What is the intended benefit? [...] I assumed so, the intended benefit was that:

* shellcheck would not complain,

* we get less possible ways to invoke the script in the wrong way,

but as the variable is filled by the one making the packages excluding the rule will make more sense.

This is not a shell script but a Makefile, so the whole file should be ignored.