search

DOMjudge / domjudge-packaging

DOMjudge packaging for (Linux) distributions and live image
32 stars 40 forks source link

Docker build using debian:latest #43

Closed coffeeneer closed 5 years ago

coffeeneer commented 5 years ago

Sorry to bother you guys again.

Recently the docker debian:latest tag changed distro version to "buster" (10?). My previous issue with php-mcrypt being deprecated with the php version used in buster is not the only issue in debian buster.

The judgehost dockerfile includes installation of openjdk-8-jdk, which does not exist in the default sources of debian buster.

There's a few solutions for this, either adding a source for the openjdk 8, using default-jdk (java 11 in buster) or pinning the base image to debian:stretch.

Now java 11 is quite different from 8 and and I've run into issues quite often with running applications developed in 8 on a version 11 jre. So I have chosen the last option for now, knowing that I've had domjudge running stable with debian stretch.

I'd love to hear your opinion on this.

nickygerritsen commented 5 years ago

Interesting question this.

Our default dj_make_chroot uses default-jre-headless (see here), so I think it makes sense to also update the Docker images to use that, but maybe others want to give their opinion?

thijskh commented 5 years ago

Makes sense to me to use the OS default

nickygerritsen commented 5 years ago

I have updated all our Dockerfiles to use the default JRE/JDK. I have also pushed new images to Docker Hub.