DOMjudge / domjudge-packaging

DOMjudge packaging for (Linux) distributions and live image
31 stars 37 forks source link

Remove reference to submitdir in domserver Dockerfile #55

Closed tom93 closed 4 years ago

tom93 commented 4 years ago

It was removed in DOMjudge/domjudge@d66725038, causing the chown command to fail.

This change will cause issues if the new Dockerfile is used with an older release that still has a submissions directory: the directory will no longer be readable/writable by the www-data user. I'm not sure if that's a problem.

nickygerritsen commented 4 years ago

Probably it’s better to add a if [[ -d bla ]] around this line so we can still build valid images for older versions.

nickygerritsen commented 4 years ago

Thanks!