DOMjudge / domjudge-packaging

DOMjudge packaging for (Linux) distributions and live image
31 stars 37 forks source link

Build gitlabci file when accepted to main branch. #75

Closed vmcj closed 3 years ago

vmcj commented 3 years ago

If we create a protected environment we can even push to another registry for the other containers without giving away the token.

vmcj commented 3 years ago

I like this. For the contributor image we can also push it to gitlab I guess. No need to have it on docker hub if we update the compose file.

For the main images this is a bit harder since it requires a zip to be present on the website with the release. We could make a manual step (or multiple) and ask for the version to build.

you can run: https://gitlab.com/mvasseur/domjudge-packaging/-/pipelines/new

ofcourse the mvasseur might not be the best project to run this from.

vmcj commented 3 years ago

@nickygerritsen for the variables I might need some help from you or would like you to set this up (as you've done it before)

Do you think you want the idea to also build via gitlab? (so with the protected environments), as I think I can incorporate it, but if its not wanted I rather not fill the template with unused jobs.

nickygerritsen commented 3 years ago

@nickygerritsen for the variables I might need some help from you or would like you to set this up (as you've done it before)

Do you think you want the idea to also build via gitlab? (so with the protected environments), as I think I can incorporate it, but if its not wanted I rather not fill the template with unused jobs.

Currently I am always the one building the docker images so if we can automate it it is less work for me. Less work = more better

vmcj commented 3 years ago

Currently I am always the one building the docker images so if we can automate it it is less work for me. Less work = more better

See f17da2d for a possible implementation, we should check if it works when DOMjudge 8.0 is released. But if this indeed works as how I think it works you don't have to be the only one anymore who can release... although its probably with your DOMjudge credentials.