Improve domjudge infrastructure

DOMjudge / domjudge-packaging

DOMjudge packaging for (Linux) distributions and live image

31 stars 37 forks source link

Improve domjudge infrastructure #95

Closed incaseoftrouble closed 2 years ago

incaseoftrouble commented 2 years ago

Closes #94

Sorry for throwing multiple things into one, I can pick them apart if needed.

Things I added:

php version is now automatically detected
make dist is run for the build.sh so one can use a local tarball
"one-shot" customization done by start.sh (e.g. php configuration) are moved into the dockerfile (configure.sh), so one could overwrite these changes with a bind mount
start.sh now runs additional scripts at the end (can be supplied with bind mounts)
small improvements to the dockerfile

The start.sh infrastructure actually is a bit like init.d so one could even break apart the start.sh script for ease of maintenance.

incaseoftrouble commented 2 years ago

I'll do that!

incaseoftrouble commented 2 years ago

One more change: After trying it out, I found out the following problem:

During the start script, the symfony cache is created
The "add remote user" scripts modify the firewall settings
webapp cache:clear generates a new container (with the new settings)
BUT also leaves the old container in the var/cache/prod/ directory - so there are two ContainerXXXXX folders there
They are named randomly and the first one is chosen
=> The new settings are not applied on some starts

This can be fixed by running webapp cache:clear twice or applying the modifications before the cache is first generated. I thus split up the start.sh script in parts, so that one can (somewhat) choose when the modifications are applied.

incaseoftrouble commented 2 years ago

Ok, everything should be fixed now. I tested the build locally.

I also modified the judgehost builds to be "symmetric" in structure as far as possible.

I also split up the overall build script a bit, so you can ./build-domjudge my_local_domjudge, useful if you work on a fork.

I only need to figure out how to make it build on gitlab - but thats some subtle issue with the default shell there ... I'll to one final squash once that works, I have to send a barrage of commits to check what works, sorry for that

vmcj commented 2 years ago

@incaseoftrouble do you want to fixup the last commit or can it be merged? We'll push new containers after its merged.

incaseoftrouble commented 2 years ago

I can fixup if you prefer but I guess the posix change is a sensible commit by itself :)