search

DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
703 stars 249 forks source link

Static scoreboard links should be relative #2070

Open troy2914 opened 1 year ago

troy2914 commented 1 year ago

seen using 8.3.0DEV/471813069 the /public?static=1 scoreboard emits bits like this:

/favicon.ico
/images/*
/css/*
/style_domjudge.css
/markdown-preview

all those items should be relative (and any others I missed to list). This allows one to use the static website under a subdir, without having to tweak it.

nickygerritsen commented 1 year ago

I don’t think we can fix this easily. It might be our zip does do this though, so I will check if that’s the case and next year we use that logic

vmcj commented 4 months ago

I don’t think we can fix this easily. It might be our zip does do this though, so I will check if that’s the case and next year we use that logic

According to https://symfony.com/doc/current/routing.html we can pass a constant (UrlGeneratorInterface::RELATIVE_PATH) for this, would that give problems @nickygerritsen ?

nickygerritsen commented 4 months ago

We can test this. I’m not sure