DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
703 stars 249 forks source link

default `configure` does not install service files for judgedaemon, docs do mention those. #2086

Open vmcj opened 1 year ago

vmcj commented 1 year ago

Description of the problem

When you follow the manual we mention the service files so you can start a judgehost with a service. The problem is that we don't advice the fhs flag which does set this.

We can fix this in multiple ways:

In my opinion we should go for either option {3,4} or discuss {1}.

@eldering what are your thoughts?

eldering commented 8 months ago

I think we can also (try to) install the service files when not in FHS mode, although that might fail if the user runs make judgehost-install without root. I don't understand though why systemd_unitdir isn't set at https://github.com/DOMjudge/domjudge/blob/main/judge/Makefile#L36 from https://github.com/DOMjudge/domjudge/blob/main/configure.ac when FHS is not enabled.

vmcj commented 7 months ago

I think we can also (try to) install the service files when not in FHS mode, although that might fail if the user runs make judgehost-install without root. I don't understand though why systemd_unitdir isn't set at https://github.com/DOMjudge/domjudge/blob/main/judge/Makefile#L36 from https://github.com/DOMjudge/domjudge/blob/main/configure.ac when FHS is not enabled.

@eldering I think we discussed and agreed that if you don't do FHS mode we (should and ) will not install service files anymore.

So that requires a change in de documentation.

eldering commented 7 months ago

Indeed, I'd propose to never install systemd unit files, in the same way that we don't install the apache or nginx config in /etc/, but just document how you can symlink/copy them. That will remove a good bit of complexity from our configure/makefile setup.