search

DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
712 stars 250 forks source link

Cannot view inactive judging on jury submission page #2191

Closed eldering closed 5 months ago

eldering commented 10 months ago

Description of the problem

When I browse to a submission on the jury interface that has multiple judgings, then I cannot view an inactive judging.

Your environment

Current main branch, both at BAPC and my laptop.

Actual behaviour

See below screenshot for URL http://localhost/domjudge/jury/submissions/106?jid=106, but it still shows the currently active judging 107. image

meisterT commented 9 months ago

I cannot reproduce this behavior, neither in Chrome nor firefox. Did you type in the URL or did you click on the respective row in the judgings table?

meisterT commented 9 months ago

While trying to provoke the issue, I found another one: image

Note that the order in this table should be by judgingid, see https://github.com/DOMjudge/domjudge/blob/main/webapp/src/Controller/Jury/SubmissionController.php#L221

I don't see where we would reorder things though.

meisterT commented 5 months ago

I think this is fixed, feel free to re-open if you can still repro.