DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
712 stars 250 forks source link

Use a Symfony Form for jury clarifications. #2322

Closed nickygerritsen closed 6 months ago

nickygerritsen commented 7 months ago

Also sanitize only after converting to markdown. Fixes #2311

meisterT commented 6 months ago

Code looks fine, feel free to merge. But I do have a couple more suggestions/nits (will write separate comments for each):

code blocks for teams do not look right in preview: image

Once sent, it looks ok: image

Interestingly enough the same works on the jury side: image

meisterT commented 6 months ago

The reply button after starting a reply is useless and collapses the reply-form. I think it should be replaced by the "send" button: image

meisterT commented 6 months ago

The reply form looks like a Matryoshka of boxes and clutter, remove at least these two:

image

Then "message" is unnecessary as there is only one text field and I don't see a use case to change the subject in a reply.

nickygerritsen commented 6 months ago

Note that your comments are all about the team clarification page, which I didn't even touch. I do agree with the remakrs so we should fix them for sure.