search

DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
712 stars 250 forks source link

Last poll time is a decimal, so Doctrine uses strings by default when… #2325

Closed nickygerritsen closed 6 months ago

nickygerritsen commented 6 months ago

… fetching from the database.

The Symfony debug bar complained about this.

nickygerritsen commented 6 months ago

Decimals aren't safe to put in a float since you loose precision, so they use strings. if you want floats, use FloatType. Which we could do here but then the database column type will change as well to DOUBLE PRECISISON from DECIMAL(X,Y)

nickygerritsen commented 6 months ago

Decimals aren't safe to put in a float since you loose precision, so they use strings. if you want floats, use FloatType. Which we could do here but then the database column type will change as well to DOUBLE PRECISISON from DECIMAL(X,Y)

If we are going to change the column type I'd vote to do that in a different PR btw. But I'm not sure if we should do that at all.