DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
712 stars 250 forks source link

Exporting a problem with a custom validator produces invalid ZIP: custom output validator is missing #2327

Closed nickygerritsen closed 6 months ago

nickygerritsen commented 6 months ago

Description of the problem

When downloading the ZIP of a problem with a custom validator, we write to the problem.yaml:

validation: custom

But we do not add the custom validator files to the ZIP file.

We also write:

special_compare='circuitdesign_cmp'

to domjudge-problem.ini. We need to make sure this doesn't hurt (but looking at the code it seems to overwrite this with a custom validator if it comes in the ZIP)

Your environment

DOMjudge version: f79b0c7d63dcdefcd438bac5de7e1757fbfa68a6

Steps to reproduce

Download the ZIP for problem C from nwerc18 from demoweb and try to import this again on a different instance.

Expected behaviour

Problem gets imported correctly.

Actual behaviour

You get an error: Custom validator specified but not found.