Fix new DB load script.

DOMjudge / domjudge

DOMjudge programming contest jury system

https://www.domjudge.org

GNU General Public License v2.0

709 stars 248 forks source link

Fix new DB load script. #2374

Closed meisterT closed 4 months ago

meisterT commented 4 months ago

In particular:

support spaces in filenames
print actual list of choices
only list files as choices, and only files with suffix .sql.gz
start indexing with 1 as this script is meant to be run by humans

vmcj commented 4 months ago

* print actual list of choices
Out of interest, what failed?

meisterT commented 4 months ago

I assume you tested it, and it does look easier to read.

Yep, tried to load a dump with spaces and then run into this.

* print actual list of choices
Out of interest, what failed?

The previous code didn't list any choices with indices for me at all, should it have?

vmcj commented 4 months ago

I assume you tested it, and it does look easier to read.

Yep, tried to load a dump with spaces and then run into this.
* print actual list of choices
Out of interest, what failed?
The previous code didn't list any choices with indices for me at all, should it have?

yes, pretty sure it did at one point for me.