DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
703 stars 249 forks source link

Initial code for a mobile friendly scoreboard. #2447

Open nickygerritsen opened 3 months ago

nickygerritsen commented 3 months ago

Missing:

But we want to use this for the public scoreboard in Luxor, so hence this initial PR.

meisterT commented 3 months ago

Maybe not do this on non public scoreboards?

Agreed.

What is strange: I looked now on my phone (and not with chrome devtools) and it is way too wide... but only until the first refresh, then it's fine. Do we fix the width too late?

nickygerritsen commented 3 months ago

Might be that I broke something when moving this to the js file. Will check

meisterT commented 3 months ago

I quickly looked into the hearts. It is non-trivial to re-use the same code, so we might have to duplicate it.

nickygerritsen commented 3 months ago

Might be that I broke something when moving this to the js file. Will check

Should be fixed now, it indeed executed the javascript before the page was loaded, which broke when I moved the code to the .js file.

It now also only shows the mobile scoreboard on the public page.