DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
701 stars 249 forks source link

Don't set the empty string as we display it on the scoreboard #2538

Closed vmcj closed 1 month ago

vmcj commented 1 month ago

We state we fallback but would pick the empty string now,

meisterT commented 1 month ago

I seem to remember that we also had an issue with nulls but cannot find it quickly in the code.

vmcj commented 1 month ago

I seem to remember that we also had an issue with nulls but cannot find it quickly in the code.

I do remember the same, but PHPStan seems to be happy so it should be allowed. I think I do prefer null for this specific case or to make the choice explicit here, so if display_name is not set start to guess on something else, the earlier code did not do that so I didn't add it but this feels a bit like having too many fields for the same thing.