search

DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
701 stars 249 forks source link

Replace data sources with shadow mode #2587

Closed nickygerritsen closed 3 weeks ago

nickygerritsen commented 4 weeks ago

Fixes #2087

This makes the API always use external ID's and use sane defaults for the field if not provided.

vmcj commented 3 weeks ago

Overall I think this is good and we just need a contest to prove that it works but it would be good if someone else also takes a good look.

meisterT commented 3 weeks ago

It seems to be possible to modify the external IDs in the UI (might have been the case before). That seems asking for trouble.

nickygerritsen commented 3 weeks ago

It seems to be possible to modify the external IDs in the UI (might have been the case before). That seems asking for trouble.

This was always possible yes. Are you proposing we disallow this after creation? I.e. only add it for new entities?

meisterT commented 3 weeks ago

That is my proposal indeed, but since you didn't introduce it in this PR, let's do in a separate one if you agree