DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
739 stars 258 forks source link

Exclude samples for interactive problems. #2718

Closed eldering closed 1 month ago

eldering commented 2 months ago

(cherry picked from commit 0cc0da082f9d96a0cc653755d4e22fb837a3c84d)

sentry-io[bot] commented 2 months ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: webapp/src/Service/DOMJudgeService.php

Function Unhandled Issue
App\Service\DOMJudgeService::getSamplesZipForContest Doctrine\ORM\NoResultException: No result was found for query although at least one row was expected. /src/Service/DOMJudgeService.php in...
Event Count: 2

Did you find this useful? React with a 👍 or 👎

Kevinjil commented 2 months ago

Wouldn't it be nicer if we do not allow downloading a sample zip for interactive problems, instead of supplying an empty zip?

meisterT commented 2 months ago

This code path is the overall zip with all samples, and we still include the attachments, so it is not empty.