DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
739 stars 259 forks source link

Change the line chart to a bar chart. #2727

Closed as6325400 closed 1 month ago

as6325400 commented 2 months ago

Bar Chart

Bar Chart

Origin Chart

Origin Chart

It has been changed to a bar chart. Personally, I don't think the difference is significant.

mpsijm commented 2 months ago

I do prefer the bar chart, makes it clearer that we're looking at individual submissions per bin :smile: Talking about bins, what was the idea again for contests that run for (way) longer than 5 hours? :slightly_smiling_face:

Also, the x-axis looks off: why does it use multiples of 17 instead of 15? :thinking:

as6325400 commented 2 months ago

I do prefer the bar chart, makes it clearer that we're looking at individual submissions per bin 😄 Talking about bins, what was the idea again for contests that run for (way) longer than 5 hours? 🙂

Also, the x-axis looks off: why does it use multiples of 17 instead of 15? 🤔

Regarding the x-axis, it's likely due to RWD (Responsive Web Design). The original version also adjusts the ticks automatically, so I'll take a look into it later.

As for the bins, I think we can set it to max(300, number of minutes) bins, since most contests don't exceed 5 hours.

as6325400 commented 1 month ago

Is it acceptable to use max(300, number_of_minutes) as the interval count?

Should I submit this change in this PR?

meisterT commented 1 month ago

Merging this as is - let's do it max bucketing and ticks in a separate PR.

as6325400 commented 1 month ago

Merging this as is - let's do it max bucketing and ticks in a separate PR.

ok