DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
739 stars 259 forks source link

Memory usage does not get reported #2763

Closed eldering closed 3 weeks ago

eldering commented 1 month ago

Description of the problem

It was reported by @RagnarGrootKoerkamp that "a submission goes out of memory, yet shows 0B memory usage. Memory here should only grow in factors of 2, so it shouldn't go from 0 to a failing too large allocation, so somehow the memory measurement is underreporting."

image

All submissions at BAPC report 0 bytes memory usage.

Your environment

At BAPC 2024 running current main branch including group v2.

Kevinjil commented 1 month ago

As noted in the Slack channel, this is reported in the compilation metadata:

internal-warning: Kernel too old and does not support memory.peak
eldering commented 1 month ago

As noted in the Slack channel, this is reported in the compilation metadata:

internal-warning: Kernel too old and does not support memory.peak

Note that BPAC runs on Ubuntu 22.04, kernel 5.15.0.

Kevinjil commented 1 month ago

The memory.peak was introduced here: https://lore.kernel.org/all/20220507050916.GA13577@us192.sjc.aristanetworks.com/T/#u

It is introduced in v5.19 and v6.5

nickygerritsen commented 1 month ago

PC^2 does not report peak usage on these older kernels for this reason

meisterT commented 3 weeks ago

I have an older kernel, but it is recorded for me... weird.

$ cat /proc/version
Linux version 6.1.0-26-amd64 (debian-kernel@lists.debian.org) (gcc-12 (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40) #1 SMP PREEMPT_DYNAMIC Debian 6.1.112-1 (2024-09-30)
meisterT commented 3 weeks ago

Ah, it's already in 6.0: image

Kevinjil commented 3 weeks ago

Ah, it's already in 6.0:

Hmm good catch. The search function was just utterly borked :|