All of those actions are default system command like creating or cleaning up needed files/directories. Those should never fail so if they do we can't really trust this judgehost anymore until we inspected the host.
Leftover is the disabling of debug_scripts when we can't run those as we don't have a dependant entity like for languages/problems which we can disable in its place. The closest thing would be the default_debug_script key in the config which is a bit brittle. A suggestion is to either store this as a fact with the executable or put in the work to remove this as the default option in the config.
Also swapped one function to the non-internal function which handles the disabling already.
All of those actions are default system command like creating or cleaning up needed files/directories. Those should never fail so if they do we can't really trust this judgehost anymore until we inspected the host.
Leftover is the disabling of debug_scripts when we can't run those as we don't have a dependant entity like for languages/problems which we can disable in its place. The closest thing would be the
default_debug_scriptkey in the config which is a bit brittle. A suggestion is to either store this as a fact with the executable or put in the work to remove this as the default option in the config.Also swapped one function to the non-internal function which handles the disabling already.
This is part of https://github.com/DOMjudge/domjudge/pull/2745 but as that PR handles 3 semi-unrelated fixme's it's better to keep the discussion separate.