search

DOMjudge / domjudge

DOMjudge programming contest jury system
https://www.domjudge.org
GNU General Public License v2.0
732 stars 256 forks source link

Decide how to proceed with current special casing in ICPC-live #379

Closed meisterT closed 6 years ago

meisterT commented 6 years ago

Examples for special cases: https://github.com/DOMjudge/domjudge/commit/d9a5d909d421ec6850bda411b1ed75ec207f1f13 and https://github.com/DOMjudge/domjudge/commit/fcf4df06261da5092895b5a94efdc75a20f3366e and https://github.com/DOMjudge/domjudge/commit/7358f7e48253620751ccba0ca4a39f241d42ac7a

Can we solve this with the mapping in lib/lib.misc.php?

thijskh commented 6 years ago

I've decided to merge all three:

  1. Is not harmful to merge, can improve on it later if we have a better solution.
  2. Just merged (adjusted to master codebase).
  3. Merged using definedness of ICAT_URL as feature toggle.

You say "examples", is there more to this issue?

meisterT commented 6 years ago

I just wasn't sure if my list is complete.

thijskh commented 6 years ago

Closing then since it now lacks concrete actions to take.