search

DOOMer / screengrab

Crossplatform tool for fast making screenshots.
http://screengrab.doomer.org/
GNU General Public License v2.0
23 stars 8 forks source link

Remove qxt include source and use from oficial project, needed for packagin #11

Closed mckaygerhard closed 11 years ago

mckaygerhard commented 12 years ago

Its necesary to remove qxt include source and use from oficial project, needed for packagin.

The packagin process are very tedius due include embebed source of qxt libs into project.. not integrate to sistem libqxt an make confising or dificult packagin.. for debian and other debian derivated distros.

Theres any option to do not use internat embebed qxt code?

DOOMer commented 12 years ago

Only some code from Qxt lib used, not all Qxt lib. Why it's can create problems for packaging in Debian-based (and other distro)?

mckaygerhard commented 12 years ago

due must use system library, not embebed! for generated deendences..

its also better for organize..

On Wed, Sep 19, 2012 at 12:20 PM, Artem Galichkin notifications@github.comwrote:

Only some code from Qxt lib used, Why it's can create problems for packaging in Debian-based (and other distro)?

— Reply to this email directly or view it on GitHubhttps://github.com/DOOMer/ScreenGrab/issues/11#issuecomment-8697724.

Lenz McKAY Gerardo (PICCORO) http://qglochekone.blogspot.com

DOOMer commented 12 years ago

in some next days I'm will decide about adding new build option for using system version Qxt library. And implement it to code.

mckaygerhard commented 12 years ago

please! and many thanks, please do some hurry . i'll contac another projects authors to do the same.. as u

this will solve issues for compiling and package into debin based distros..

On Wed, Sep 19, 2012 at 12:49 PM, Artem Galichkin notifications@github.comwrote:

in some next days I'm will decide about adding new build option for using system version Qxt library. And implement it to code.

— Reply to this email directly or view it on GitHubhttps://github.com/DOOMer/ScreenGrab/issues/11#issuecomment-8698803.

Lenz McKAY Gerardo (PICCORO) http://qglochekone.blogspot.com

DOOMer commented 12 years ago

this will solve issues for compiling and package into debin based distros..

You are debian maintainer and want maintain my app in this Debian?

mckaygerhard commented 12 years ago

i will promote.. but i am not debian oficial mantainer.. i have related derivate, veenux GNU/Linux debian distro by FSF http://www.gnu.org/distros/free-distros.es.html i need to collaborat between debian and venenux for common purposes

On Thu, Sep 20, 2012 at 1:20 PM, Artem Galichkin notifications@github.comwrote:

this will solve issues for compiling and package into debin based distros..

You are debian maintainer and want maintain my app in this Debian?

— Reply to this email directly or view it on GitHubhttps://github.com/DOOMer/ScreenGrab/issues/11#issuecomment-8739405.

Lenz McKAY Gerardo (PICCORO) http://qglochekone.blogspot.com

DOOMer commented 12 years ago

I'm addbuild option for using system version of Qxt Library. Run cmake -DSG_USE_SYSTEM_QXT=ON) /path/to/CMakeLists.txt

mckaygerhard commented 12 years ago

umm, i hope that code of screen grab can be build with system qxt lib, i'll test in few days and send feedback

On Fri, Sep 21, 2012 at 12:17 PM, Artem Galichkin notifications@github.comwrote:

I'm addbuild option for using system version of Qxt Library. Run cmake --DSG_USE_SYSTEM_QXT=ON) /path/to/CMakeLists.txt

— Reply to this email directly or view it on GitHubhttps://github.com/DOOMer/ScreenGrab/issues/11#issuecomment-8773550.

Lenz McKAY Gerardo (PICCORO) http://qglochekone.blogspot.com

DOOMer commented 12 years ago

How has been testing build with -DSG_USE_SYSTEM_QXT=ON option at your distro?

mckaygerhard commented 12 years ago

actualy we are uploading a preliminary website ( pvnx.venenux.org ) and development/packagin issues related will be coninue in few days, ( more close i will take packagin related tasks next week, please be patien and many thanks)

mckaygerhard commented 11 years ago

now i'll test this on weekend, and close or report feedback sorry for late..

DOOMer commented 11 years ago

Ok, I'm be waiting results

mckaygerhard commented 11 years ago

calm down horses , not waith so much:

-- Found Qxt Libraries: QxtGui QxtWeb QxtNetwork QxtSql QxtBerkeley QxtCore
-- Global shortcuts support: ON
-- XDG_CONFIG_HOME support: ON
-- Upload to image hosings support: ON
-- Use system Qxt Library: ON
-- Documentation directory: /usr/share/doc/screengrab
-- SG_INCLUDE: /home/intranet/debian/screengrab/screengrab-1.0.0rc1/src/
-- SG_CORE_INCLUDE-2: /home/intranet/debian/screengrab/screengrab-1.0.0rc1/src/
-- Found lrelease executable: /usr/bin/lrelease-qt4
-- Generating localize ...
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
QXT_QXTCORE_INCLUDE_DIR
   used as include directory in directory /home/intranet/debian/screengrab/screengrab-1.0.0rc1
   used as include directory in directory /home/intranet/debian/screengrab/screengrab-1.0.0rc1/src/common/qkeysequencewidget
   used as include directory in directory /home/intranet/debian/screengrab/screengrab-1.0.0rc1/src/common/singleapp
   used as include directory in directory /home/intranet/debian/screengrab/screengrab-1.0.0rc1/src/modules/uploader
QXT_QXTGUI_INCLUDE_DIR
   used as include directory in directory /home/intranet/debian/screengrab/screengrab-1.0.0rc1
   used as include directory in directory /home/intranet/debian/screengrab/screengrab-1.0.0rc1/src/common/qkeysequencewidget
   used as include directory in directory /home/intranet/debian/screengrab/screengrab-1.0.0rc1/src/common/singleapp
   used as include directory in directory /home/intranet/debian/screengrab/screengrab-1.0.0rc1/src/modules/uploader

The cmake find module or whatever seachr for qxt on relative paths, and must be set to -l in /usr/lib and -L to /usr/include, currently qxt has predefined dir as "qxt" u must use include dir as /usr/include/qxt due ui file uses directly Qxtgui without this

now i'l test setting this manually

mckaygerhard commented 11 years ago

now using :

cmake -DSG_USE_SYSTEM_QXT=ON -DQXT_QXTCORE_INCLUDE_DIR=/usr/include/qxt/ -DQXT_QXTGUI_INCLUDE_DIR=/usr/include/qxt -DCMAKE_INSTALL_PREFIX=/usr ../

i got a error that i was fixed in folow lines:

Scanning dependencies of target screengrab
[ 72%] Building CXX object CMakeFiles/screengrab.dir/src/main.cpp.o
In file included from /usr/include/qxt/QxtGui/QxtGlobalShortcut:1,
                 from /home/intranet/debian/screengrab/screengrab-1.0.0rc1/src/ui/mainwindow.h:31,
                 from /home/intranet/debian/screengrab/screengrab-1.0.0rc1/src/main.cpp:25:
/usr/include/qxt/QxtGui/qxtglobalshortcut.h:28:23: error: qxtglobal.h: No existe el fichero o el directorio
In file included from /usr/include/qxt/QxtGui/QxtGlobalShortcut:1,
                 from /home/intranet/debian/screengrab/screengrab-1.0.0rc1/src/ui/mainwindow.h:31,
                 from /home/intranet/debian/screengrab/screengrab-1.0.0rc1/src/main.cpp:25:
/usr/include/qxt/QxtGui/qxtglobalshortcut.h:33: error: expected initializer before ‘:’ token
make[2]: *** [CMakeFiles/screengrab.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/screengrab.dir/all] Error 2
make: *** [all] Error 2

due global shorcut was splitted include path (fixed i think in qxt 0.6.2) , in any case i'll will report that to qxt.. globalshorcut must include as QxtCore/global.h and not directly as global.h

so i'll fixed set as:

cmake -DSG_USE_SYSTEM_QXT=ON -DQXT_QXTCORE_INCLUDE_DIR=/usr/include/qxt/QxtCore -DQXT_QXTGUI_INCLUDE_DIR=/usr/include/qxt -DCMAKE_INSTALL_PREFIX=/usr ../

note QxtCore was set different rather thatn QxtGui include path and cmpiles perfectly

DOOMer commented 11 years ago

Hmm... i'm get cmake module for find Qxt from Qxt srcs, not written by me. I'm try to rewrite it for fix this bug, in some next.days.

mckaygerhard commented 11 years ago

so also http://dev.libqxt.org/libqxt/issue/23/error-in-globalshorcut-include-to-globalh reporte due qxt has this include wrong (i think)

DOOMer commented 11 years ago

I'm can't rewrite Cmake module for fixing it. It is closed with add build note in README file.

mckaygerhard commented 11 years ago

i made report in debian an i reported already in qxt project

On Thu, Oct 18, 2012 at 5:38 PM, Artem Galichkin notifications@github.comwrote:

I'm can't rewrite Cmake module for fixing it. It is closed with add build note in README file.

— Reply to this email directly or view it on GitHubhttps://github.com/DOOMer/ScreenGrab/issues/11#issuecomment-9583196.

Lenz McKAY Gerardo (PICCORO) http://qglochekone.blogspot.com

mckaygerhard commented 11 years ago

hello, may i have to include explicy qxtcore in include module of cmake?

mckaygerhard commented 11 years ago

now changed upstream:

1) https://bitbucket.org/libqxt/libqxt/issue/23/error-in-globalshorcut-include-to-globalh 2) https://bitbucket.org/libqxt/libqxt/issue/26/change-qt-header-inclusion-style-to

now i dont know if this bug must be open or mantain closed!

but u must documented that in README file or INSTALL compilation documents