Qt 5 support - Githubissues

DOOMer / screengrab

Crossplatform tool for fast making screenshots.

http://screengrab.doomer.org/

GNU General Public License v2.0

23 stars 8 forks source link

Qt 5 support #25

Closed jleclanche closed 7 years ago

jleclanche commented 11 years ago

Does screengrab build with qt 5? No matter what I do it seems to build with qt 4.

DOOMer commented 11 years ago

Now i'm not tested build screengrab with Qt5.x. It's realy needed?

jleclanche commented 11 years ago

It would be nice, yes. It seems qt4 is hardcoded in CMakeLists.txt.

Ilya87 commented 9 years ago

Fixed here - https://github.com/QtDesktop/screengrab/commit/93dac8a15ca7501cca0a996f705374831ec651ce issue should be closed?

jleclanche commented 9 years ago

That's the lxqt fork, which will go to lxqt. Ive got no news of the author here

DOOMer commented 9 years ago

I'm return to develop yjis project and syaty v2.0 in few next days (parallel with prepare release v1.1)/ v2 will be ported on Qt5.x.

jleclanche commented 9 years ago

@DOOMer You're a bit late to the party now. I contacted you several times with no answer so we already started working on the fork :/

There's very big cleanups here: https://github.com/QtDesktop/screengrab I don't know if you want to pull them back in or something.

The plan right now is to move QtDesktop/screengrab to the LXQt architecture and rename it to lxqt-screenshot. We already ported it to Qt 5.

DOOMer commented 9 years ago

@jleclanche

Can I take your works at porting on Qt5? Can I participate in the development of fork (lxqt-screenshot)?

jleclanche commented 9 years ago

@DOOMer Yes of course; you can upstream anything you like and you're very welcome as a committer on lxqt-screenshot (and let me know if you want to work on other parts of lxqt).

You already have commit access to QtDesktop/ScreenGrab from a long time ago. Feel free to work on it. Keep in mind though, we dropped some features that your version of screengrab provides (such as Windows support to ease qt5 porting).

jleclanche commented 9 years ago

@DOOMer Until the fork is ready to land into lxqt, it will stay in QtDesktop, so until then all work on it happens there.

DOOMer commented 9 years ago

@jleclanche I merged all QtDesktop's changes to my master branch. I have plan use QtDesktop branch for next some works (continue port on Qt5, replacesome my old code with Qt5-classes). And my personal upstream repo i want to user for work with windows-specific code.

I would like to know what kind of things yet to be done in screengrab for adaptation under lxqt?

jleclanche commented 9 years ago

@DOOMer So the changes still to remain if we are still to move it to lxqt-screenshot:

Link to liblxqt
Create a man page documenting the tool
Remove the About menu, seeing as it would be a lxqt component.
Some other bits which make it more tighly integrated with LXQt

That said, I'm not sure it's 100% necessary to do all this. We could have it released as lxscreenshot-qt and have it remain a "third party app maintained by the lxqt team". Maybe that would be more relevant, and it wouldn't be on the LXQt release schedule then; it'd be like lximage-qt.

AlexWayfer commented 7 years ago

No news about this? :(

jleclanche commented 7 years ago

@AlexWayfer screengrab has moved here: https://github.com/qtdesktop/screengrab

That version supports Qt5.