search

DOREMUS-ANR / knowledge-base

Repository containing controlled vocabularies and data published by DOREMUS
http://data.doremus.org/
Apache License 2.0
16 stars 7 forks source link

Proposal of skeleton for the pivot of genres #41

Closed pasqLisena closed 6 years ago

pasqLisena commented 7 years ago

Doubts:

rtroncy commented 7 years ago

The concept scheme URI <http://data.doremus.org/vocabulary/genre/> is perfect.

You should not use owl:sameAs but skos:exactMatch since you're aligning skos:Concept

Why do you have the lines 18-21 ? This is hijacking the definition of some concepts belonging to a different vocab, namely iaml/genre

Line 51 seems also wrong. You should define <http://data.doremus.org/vocabulary/genre/v> perhaps but not <http://data.doremus.org/vocabulary/iaml/genre/v> for sure.

pasqLisena commented 7 years ago

Why do you have the lines 18-21 ? This is hijacking the definition of some concepts belonging to a different vocab, namely iaml/genre

Do you think so? It is just adding a skos:narrower relation. The alternative is "duplicate" the lit concept as <http://data.doremus.org/vocabulary/genre/lit>.

Line 51 seems also wrong. You should define http://data.doremus.org/vocabulary/genre/v perhaps but not http://data.doremus.org/vocabulary/iaml/genre/v for sure.

Ups, typo.

rtroncy commented 7 years ago

Do you think so? It is just adding a skos:narrower relation.

Those lines are reproduced below:

<http://data.doremus.org/vocabulary/iaml/genre/lit> skos:narrower 
   <http://data.doremus.org/vocabulary/iaml/genre/lid>, 
   <http://data.doremus.org/vocabulary/iaml/genre/lod>, 
   <http://data.doremus.org/vocabulary/iaml/genre/lyh>, 
   <http://data.doremus.org/vocabulary/iaml/genre/vrl>

They just relate a iaml genre with other iaml genres and as such, those relationships should be declared in the genre iaml concept scheme.

The alternative is "duplicate" the lit concept as <http://data.doremus.org/vocabulary/genre/lit>.

This is another objective but the lines 18-21 do not do this.