DOSull / weaving-space

tools for making tileable weave units that give the appearance of a woven material for multivariate thematic mapping
MIT License
19 stars 0 forks source link

When aspect = 1 and margin > 0 the strands get trimmed inside the tile #4

Closed DOSull closed 2 years ago

DOSull commented 2 years ago

For example w = get_weave_unit(weave_type = "cube", aspect = 1, margin = 500, strands = "ad-|b-e|-cf") gives image in earlier code we generated 'augmented' matrices so there was extra strand overlapping the tile extent. Now this only happens when aspect < 1

DOSull commented 2 years ago

LOL... the R code checks and throws an error when you try to make a tile like this, suggesting that you set the margin to 0 and apply a negative buffer to any final map! Surely we can do better than this...

DOSull commented 2 years ago

Added warning messages and advice. This is very hard to fix under the current implementation