Split topology/network from saga-watem

DOV-Vlaanderen / saga-watem

SAGA-WaTEM modules for calculating erosion

https://dov-vlaanderen.github.io/saga-watem/

GNU Lesser General Public License v3.0

0 stars 0 forks source link

Split topology/network from saga-watem #15

Open Sachagobeyn opened 4 months ago

Sachagobeyn commented 4 months ago

Move topology/network to general SAGA-module

johanvdw commented 2 months ago

I'm doing this for a number of modules:

line direction (was added to saga yesterday)
topologize + upstream edges (will propose today)

However two modules are so specific to watem-sedem I think they should stay here:

routing shape
segment catchment/segment_catchment.cpp

They are actually post-processing libraries of watem-sedem, and have no use outside that.

Sachagobeyn commented 2 months ago

Hi Johan,

routing shape: I agree, the structure depends on the (output) structure of WaTEM/SEDEM.
segment catchment/segment_catchment.cpp: I haven't used it yet,

Question: in which library are the line direction and topologize / upstream edges put in SAGA? Where will the routingshapoe / segmentcatchment end up? Latter: I would guess the watem/sedem library?

johanvdw commented 2 months ago

in shapes_lines: [16] Topologize Polylines [17] Upstream Edges

in shapes_grid: [20] Line Direction

I'm indeed in favor of moving the other modules, which are now under 'topology' to 'watem_sedem' (we can show it as Watem/Sedem in the gui).

Sachagobeyn commented 2 months ago

Ok, let me know if need help documenting the functionalities